add --disabled-controllers #77
Merged
+42
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
kind/feature
Contributor
|
LGTM label has been added. Git tree hash: a9711ddb907f1b0a8b2641c0660a9ff30d14372c
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to make it possible to have an agent running without it actively managing the CRDs (APIResourceSchemas) in kcp. Instead of adding a dedicated run mode sort of thing to the agent, we decided to instead allow to toggle individual controllers. This will not just allow to run a "sync-only" agent, but also to have a "CRD-only no-sync-pls" agent.
What Type of PR Is This?
/kind feature
Related Issue(s)
part of #74
Release Notes